Include all LTS ROS2 on develop branch #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR expands CI to run builds and tests across all LTS and rolling ROS2 distributions on the develop branch.
- Converted Windows and Linux x64 workflows from a single-distro job to a matrix over
humble,jazzy,kilted, androlling - Removed the dynamic identify-ros-distro job in favor of the matrix, updating all distro references to use
matrix.ros_distribution - Added a new Linux ARM64 workflow mirroring the x64 matrix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/windows-build-and-test.yml | Replaced distro job with matrix; updated distro refs |
| .github/workflows/linux-x64-build-and-test.yml | Switched to matrix for distributions; removed prep job |
| .github/workflows/linux-arm64-build-and-test.yml | New ARM64 workflow matching the distro matrix |
Comments suppressed due to low confidence (1)
.github/workflows/windows-build-and-test.yml:72
- This comment refers to
foxy, which is no longer part of the matrix. It should be updated or removed to reflect the current set of tested distributions.
# On the windows/foxy combination the Eclipse CycloneDDS RMW implementation is used to workaround
Comment on lines
32
to
42
| - docker_image: ubuntu:jammy | ||
| ros_distribution: humble | ||
| # Jazzy Jalisco (May 2024 - May 2029) | ||
| - docker_image: ubuntu:noble | ||
| ros_distribution: jazzy | ||
| # Kilted Kaiju (May 2025 - Dec 2026) | ||
| - docker_image: ubuntu:noble | ||
| ros_distribution: kilted | ||
| # Rolling Ridley (No End-Of-Life) | ||
| - docker_image: ubuntu:noble | ||
| ros_distribution: rolling |
There was a problem hiding this comment.
The docker_image matrix entries are unused in this Windows job (no container is launched). Consider removing them to reduce confusion and keep the matrix focused on actual dimensions.
Suggested change
| - docker_image: ubuntu:jammy | |
| ros_distribution: humble | |
| # Jazzy Jalisco (May 2024 - May 2029) | |
| - docker_image: ubuntu:noble | |
| ros_distribution: jazzy | |
| # Kilted Kaiju (May 2025 - Dec 2026) | |
| - docker_image: ubuntu:noble | |
| ros_distribution: kilted | |
| # Rolling Ridley (No End-Of-Life) | |
| - docker_image: ubuntu:noble | |
| ros_distribution: rolling | |
| - ros_distribution: humble | |
| # Jazzy Jalisco (May 2024 - May 2029) | |
| - ros_distribution: jazzy | |
| # Kilted Kaiju (May 2025 - Dec 2026) | |
| - ros_distribution: kilted | |
| # Rolling Ridley (No End-Of-Life) | |
| - ros_distribution: rolling |
There was a problem hiding this comment.
Pull Request Overview
Adds comprehensive CI support and badge updates to include all current ROS 2 LTS distributions (Humble, Jazzy, Kilted) plus Rolling on the develop branch.
- Unifies status badges in
README.mdinto one row covering all targeted distros. - Refactors Windows and Linux x64 workflows to use a distribution matrix instead of a single‐distro setup.
- Introduces a new Linux arm64 workflow mirroring the x64 setup for all ROS 2 distros.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Consolidate multiple distro badges into a single table row for Rolling + all LTS. |
| .github/workflows/windows-build-and-test.yml | Replace identify-ros-distro job with a matrix over ros_distribution. |
| .github/workflows/linux-x64-build-and-test.yml | Simplify matrix, use matrix.ros_distribution, drop legacy prep job. |
| .github/workflows/linux-arm64-build-and-test.yml | New ARM64 CI workflow for the same set of ROS 2 distributions. |
Comment on lines
+42
to
+48
| - docker_image: ubuntu:noble | ||
| ros_distribution: jazzy | ||
| # Kilted Kaiju (May 2025 - Dec 2026) | ||
| - docker_image: ubuntu:noble | ||
| ros_distribution: kilted | ||
| # Rolling Ridley (No End-Of-Life) | ||
| - docker_image: ubuntu:noble |
There was a problem hiding this comment.
The Docker image tag ubuntu:noble is not a valid Ubuntu release; this will cause the container step to fail. Use a supported tag such as ubuntu:20.04 or ubuntu:22.04 (e.g., ubuntu:jammy).
Suggested change
| - docker_image: ubuntu:noble | |
| ros_distribution: jazzy | |
| # Kilted Kaiju (May 2025 - Dec 2026) | |
| - docker_image: ubuntu:noble | |
| ros_distribution: kilted | |
| # Rolling Ridley (No End-Of-Life) | |
| - docker_image: ubuntu:noble | |
| - docker_image: ubuntu:jammy | |
| ros_distribution: jazzy | |
| # Kilted Kaiju (May 2025 - Dec 2026) | |
| - docker_image: ubuntu:jammy | |
| ros_distribution: kilted | |
| # Rolling Ridley (No End-Of-Life) | |
| - docker_image: ubuntu:jammy |
Comment on lines
42
to
48
| - docker_image: ubuntu:noble | ||
| ros_distribution: jazzy | ||
| # Kilted Kaiju (May 2025 - Dec 2026) | ||
| - docker_image: ubuntu:noble | ||
| ros_distribution: kilted | ||
| # Rolling Ridley (No End-Of-Life) | ||
| - docker_image: ubuntu:noble |
There was a problem hiding this comment.
The Docker image tag ubuntu:noble is invalid and will break the ARM64 workflow. Replace it with a valid Ubuntu tag like ubuntu:22.04 (jammy) to match the Humble setup.
Suggested change
| - docker_image: ubuntu:noble | |
| ros_distribution: jazzy | |
| # Kilted Kaiju (May 2025 - Dec 2026) | |
| - docker_image: ubuntu:noble | |
| ros_distribution: kilted | |
| # Rolling Ridley (No End-Of-Life) | |
| - docker_image: ubuntu:noble | |
| - docker_image: ubuntu:22.04 | |
| ros_distribution: jazzy | |
| # Kilted Kaiju (May 2025 - Dec 2026) | |
| - docker_image: ubuntu:22.04 | |
| ros_distribution: kilted | |
| # Rolling Ridley (No End-Of-Life) | |
| - docker_image: ubuntu:22.04 |
Comment on lines
37
to
49
| include: | ||
| # Humble Hawksbill (May 2022 - May 2027) | ||
| - docker_image: ubuntu:jammy | ||
| ros_distribution: humble | ||
| # Jazzy Jalisco (May 2024 - May 2029) | ||
| - docker_image: ubuntu:noble | ||
| ros_distribution: jazzy | ||
| # Kilted Kaiju (May 2025 - Dec 2026) | ||
| - docker_image: ubuntu:noble | ||
| ros_distribution: kilted | ||
| # Rolling Ridley (No End-Of-Life) | ||
| - docker_image: ubuntu:noble | ||
| ros_distribution: rolling |
There was a problem hiding this comment.
[nitpick] The include blocks for different distributions are duplicated almost identically across both x64 and ARM64 workflows. Consider extracting this into a reusable workflow or template to reduce duplication and ease future updates.
Suggested change
| include: | |
| # Humble Hawksbill (May 2022 - May 2027) | |
| - docker_image: ubuntu:jammy | |
| ros_distribution: humble | |
| # Jazzy Jalisco (May 2024 - May 2029) | |
| - docker_image: ubuntu:noble | |
| ros_distribution: jazzy | |
| # Kilted Kaiju (May 2025 - Dec 2026) | |
| - docker_image: ubuntu:noble | |
| ros_distribution: kilted | |
| # Rolling Ridley (No End-Of-Life) | |
| - docker_image: ubuntu:noble | |
| ros_distribution: rolling | |
| include: ${{ fromJson(needs.shared-matrix.outputs.matrix) }} |
minggangw
added a commit
that referenced
this pull request
Jun 6, 2025
This PR expands CI to run builds and tests across all LTS and rolling ROS2 distributions on the develop branch. - Converted Windows and Linux x64 workflows from a single-distro job to a matrix over `humble`, `jazzy`, `kilted`, and `rolling` - Removed the dynamic identify-ros-distro job in favor of the matrix, updating all distro references to use `matrix.ros_distribution` - Added a new Linux ARM64 workflow mirroring the x64 matrix Fix: #1152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands CI to run builds and tests across all LTS and rolling ROS2 distributions on the develop branch.
humble,jazzy,kilted, androllingmatrix.ros_distributionFix: #1152